Forum OpenACS Development: Issuing a warning for deprecated procs
ns_log Warning "procedure $proc_name has been deprecated and will probably be removed eventually. Please use an alternative non-deprecated procedure instead"
The message is maybe a little over-verbose, but it is a lot better than no message at all I think.
What is the policy on when to use the warn flag? I would have thought that we always wanted to warn about the use of deprecated procs?
An example of a deprecated proc where nobody's made the effort to move to the new proc is ad_permission_p (deprecated in favor of permission::get). I guess it's a seperate question whether we should deprecate procs unless we also make the effort to actually get rid of them in the code.
I would change the message to:
ns_log Debug "Deprecated proc $proc_name used"Since it is less annoyingly long and also is Debug so isn't displayed on a production box.
I would like to see us put together a push to get rid of these deprecated procs for an upcoming release, but I don't see it as passing the triage test for 4.7. Maybe 4.8?
What we need are one or two knowledgable volunteers willing to grunt their way through the code removing references.
Don - removing a bunch of deprecated procs for 4.8 sounds like a good idea to me. That also means we should make sure that for 4.7 all procs that should be deprecated really are, so that people have some time to shift over to using newer procs.