We reverted this logging logic after our test:
ns_log Notice ">>> STARTING TMPFILE tmpfile: $tmpfile"
set tmpfile [ns_normalizepath $tmpfile]
set tmpdir [string trimright [ns_config ns/parameters tmpdir] /]
ns_log Notice ">>> UPLOADCHECK tmpfile = $tmpfile"
ns_log Notice ">>> UPLOADCHECK tmpdir = $tmpdir"
if {[ad_file dirname $tmpfile] ne $tmpdir} {
#
# File is not a direct child of the tmpfolder: not safe
#
ns_log Notice ">>> UPLOADCHECK direct child False"
#return false
}
if {![ad_file exists $tmpfile]} {
#
# File does not exist yet: safe, unless we demand for the file
# to exist.
#
ns_log Notice ">>> UPLOADCHECK file not exists"
#return [expr {!$must_exist_p}]
}
if {![ad_file owned $tmpfile]} {
#
# File does not belong to us: not safe
#
ns_log Notice ">>> UPLOADCHECK file owned False"
#return false
}
if {![ad_file readable $tmpfile]} {
#
# We cannot read the file: not safe
#
ns_log Notice ">>> UPLOADCHECK file can't read"
#return false
}
if {![ad_file writable $tmpfile]} {
#
# We cannot write the file: not safe
#
ns_log Notice ">>> UPLOADCHECK file can't write"
#return false
}
#
# The file is safe
#
return true