As Emma says, it is too late to put new code on the oacs-5-3 branch. By now, I should think everyone is aware that after we close a branch and start releases (acs core 5.3.1 alpha and .LRN 2.3.0 alpha have both been released) that NO NEW DEVELOPMENT should go into the branch.
I second what Dave says. He did a partial rewrite of general comments and it's never been finished. This would be a good opportunity to do so, perhaps.
And, if there's any way to reuse rather than copy-and-paste code, we should do it. What additional functionality is the attachment code providing in forums that shouldn't exist in general comments? The whole idea behind common services like general comments is orthagonality - the notion that the same UI, functionality, etc should be presented whenever one can make comments on an object. Per-package customization is something that should be avoided ...
