Forum OpenACS Development: Re: Screen name / real name parameter

Collapse
10: Re: Screen name / real name parameter (response to 1)
Posted by Don Baccus on 08/02/03 02:27 AM
Looks like you're nearly done, Benjamin ... let me know when you've got a patch ready to submit and we can slip it in after testing.
Collapse
11: Re: Screen name / real name parameter (response to 10)
Posted by Tilmann Singer on 10/01/03 05:31 PM
What's the status of this? In my new HEAD installation, there is a ScreenName parameter and it is being used in the registration process apparently, but I can't find the user_display::get_name proc anywhere.

And a performance related note: we definitely want to avoid plsql functions in queries. Especially pages that compile lists with more users on it, e.g. the recent-posters script of forums shouldn't use something like user_display__get_name. Propably also queries that return fewer users because it is not always possible to make sure the plsql function is only executed for the rows that are really returned by the query as far as I understand. So for those cases we need to be able to do the computing in tcl, like this: 

db_multirow -extend { display_name } recent_posters recent_posters  { } {
  set display_name [user_display::get_name -first_names $first_names -last_name $last_name -screen_name $screen_name]
}
Collapse
12: Re: Screen name / real name parameter (response to 11)
Posted by Roberto Mello on 10/01/03 07:48 PM
Til,

I have Ben's patches, that were originally made for oacs-4-6. I have been adapting them to HEAD but with the entire reorganization of the registration process, and move to /lib, plus external authentication, I have not finished it yet.

The fact that I'm in the middle of my midterms did not help either, but I should commit everything this weekend.

Did I accidentally commit a user_display:: proc? I didn't mean to.

-Roberto

Collapse
13: Re: Screen name / real name parameter (response to 12)
Posted by Tilmann Singer on 10/01/03 08:35 PM
<blockquote> Did I accidentally commit a user_display:: proc? I didn't mean to.
</blockquote>

No you didn't. I only found a few occurences of reading the ScreenName parameter in acs-subsite, that's it.

Collapse
14: Re: Screen name / real name parameter (response to 13)
Posted by Tilmann Singer on 10/01/03 08:51 PM
Isn't the whole point of the user_display::get_name that it gets used _everywhere_ instead of displaying the column values directly, which means it needs a lot of replacing in all existing packages, including some kind of audit to make sure there is no place left where the privacy rules are not obeyed?

Do the patches you are planning to commit contain such changes to packages or are they just the api?

Collapse
15: Re: Screen name / real name parameter (response to 14)
Posted by Malte Sussdorff on 10/02/03 07:57 AM
using user_display::get_name would also allow us to use the name display for countries where they read from right to left ($last_name $first_names).