Forum OpenACS Improvement Proposals (TIPs): Re: Tip #26 (Proposed): Exchange acs-mail-lite

Collapse
Posted by Tilmann Singer on
These additions are cool (for sure, haven't looked in detail yet though), but if we do change the toolkits mailing system anyway then it'd make sense to clean up the current confusing situation of having two different packages handling similar functionality, of which one has a silly name, by merging your new acs-mail-lite into acs-mail and use only that henceforth.

If done in one step then it will be easy to communicate as 'The new acs-mail' instead of having several interim stages, which reminds me on the confusion of photo-album (is the new version now part of MAIN? etc.).

Collapse
Posted by Lars Pind on
Malte,

Does the contrib version of acs-mail-lite contain all the changes that has happened to the packages version of acs-mail-lite, since you forked it?

/Lars

Collapse
Posted by Malte Sussdorff on
We forked from the version Mat Kovach provided, at least this is what we have been using. The difference from a first look at diff is that you changed it on 2nd of September, adding a check that subject contains no new lines (will be added in a few minutes) and a catch around the sending of queued items. We solved this a little bit differently, so not sure if we need to incorporate your code if the result is the same.

But maybe Tilmann is right, and we should go and take out the mail system confusion first. Which would lead me to the question, why do we have acs-mail and acs-mail-lite in the first place and what packages are using acs-mail. I mean, if we get rid of one of them my understanding is that we have to rename the mail-procs in each package, or am I utterly mistaken here (I admit, no look at the acs-mail code yet).