Forum OpenACS Development: portal fixes

I can't seem to see portal included as one of the component on the Bug Tracker.  Anyway here is a diff of some simple fixes.

Index: portal//tcl/portal-procs.tcl
===================================================================
RCS file: /home/ctk/cvsroot/ctk/packages/portal/tcl/portal-procs.tcl,v
retrieving revision 1.1
diff -u -r1.1 portal-procs.tcl
--- portal//tcl/portal-procs.tcl    9 Jul 2004 16:18:40 -0000    1.1
+++ portal//tcl/portal-procs.tcl    20 Jul 2004 14:43:30 -0000
@@ -630,7 +630,8 @@
            set master_portal_id [portal::new \
                                      -name "Shared Portal" \
                                      -owner_id 0 \
-                                    -theme_name [parameter::get -parameter DefaultThemeName] \
+                                    -theme_name [parameter::get -parameter DefaultThemeName -package_id $package_id \
+                                                      -default [parameter::get_from_package_key -package_key portal -parameter -DefaultThemeName]] \
                                      -owner_privileges {}]

            # create the admin template
@@ -639,8 +640,11 @@
                                    -name "Portal Administration" \
                                    -owner_id $package_id \
                                    -page_list {{"Portal Administration" 2_column}} \
-                                    -theme_name [parameter::get -parameter DefaultThemeName] \
+                                    -theme_name [parameter::get -parameter DefaultThemeName -package_id $package_id \
+                                                    -default [parameter::get_from_package_key -package_key portal -parameter -DefaultThemeName]] \
                                    -owner_privileges {}]
+
+

            db_foreach select_portal_datasources {} {
                if { $admin_p } {
Index: portal//tcl/theme-procs.tcl
===================================================================
RCS file: /home/ctk/cvsroot/ctk/packages/portal/tcl/theme-procs.tcl,v
retrieving revision 1.1
diff -u -r1.1 theme-procs.tcl
--- portal//tcl/theme-procs.tcl    9 Jul 2004 16:18:40 -0000    1.1
+++ portal//tcl/theme-procs.tcl    20 Jul 2004 14:43:30 -0000
@@ -51,6 +51,8 @@
        @return The theme_id

    } {
+        if {[empty_string_p $name]} { set name [parameter::get_from_package_key -package_key portal -parameter -DefaultThemeName] }
+
        return [db_string select_theme_id {}]
    }

I am also tracking another bug, when you call portal::initialize inside subsite::after_mount it seems it can't see the first page.  Really weird, must be my dev env.  It barfs at portal::page::get_id

    ad_proc -public get_id {
        {-name}         
    } {
        Return a theme's id

        @name The name of the theme, defaults to the portal default theme name
        @return The theme_id

    } {
         if { ![info exists name]} { 
             set name [parameter::get_from_package_key \
                          -package_key portal \
                          -parameter -DefaultThemeName]  
         }
        return [db_string select_theme_id {}]
    }

https://openacs.org/bugtracker/openacs/bug?bug%5fnumber=2034

While doing this, I also notice maybe it is better to have portal::page::get_id to create a new page in case it doesn't find one.  Or atleast generate a good error?  Failure of db_string get_page_id_select {} is a bit vague.

I also noticed it was bit hard to trace under subsite::after_mount.  I am unsure where was the error coming from so it took some "error" and ns_log to find it.

Are you guys kind enough to tell it is still redirecting to portal/www/admin/configure when in fact I have configured it already and initialized?  Thanks.

As far as having get_id create a portlet if one doesn't exist, that's what the old new-portal code did.  As it happens, .LRN depends on it heavily because various applet operations are called at times with no portlet created and at other times with the portlet created.

Personally I think that's gross, and rather than writing get_id to magically create portlets as a side-effect, I intend to make .LRN always create needed portlets before calling the related applet routines rather than do so sometimes and not others.