Hi David,
I coordinate much of this with Rocael by e-mail. He sent your files to me and i generate patches against HEAD. I sent back patches to Rocael audit it and them commit if it works fine.
In my fresh installation from HEAD, patches were applied and behavior was what I expect but i think Rocael could decide better if it is applicable to cvs.openacs.org.
I think problems could be in file-storage because your modified files were made with version 5.1.0a3 and HEAD is on 5.1.0a5 (at least when i generate patch against it).
A major problem could be in generall-comments. The patch works for me but I use this package from HEAD and as Jade said Daveb is working in this package in contrib to remove dependencies from acs-messaging and others..
I asked Daveb in irc today session https://openacs.org/irc/log/2004-09-14 about it and he says changes could be better against generall-comments in contrib.
Maybe you could contact Rocael or coordinate with Daveb if you have time to make changes yourself. If I could help in this way please contact me.
Thanks
Orzenil
