Forum OpenACS Development: Deprecated functions removed on HEAD

Collapse
Posted by Jeff Davis on
I removed the functions on head which were -deprecated -warn; fixed any remaining places they were used (with a few exceptions below).
ad_proc -deprecated -warn lang_sort {
ad_proc -deprecated -warn ad_locale_charset_for_locale {
ad_proc -deprecated -warn ad_locale_locale_from_lang {
ad_proc -deprecated -warn ad_locale_language_name {
ad_proc -private -deprecated -warn lang_message_register { locale key message } {
ad_proc -private -deprecated -warn lang_message_lookup {
ad_proc -deprecated -warn lang_babel_translate {
ad_proc -deprecated -warn ad_locale {
ad_proc -deprecated -warn ad_locale_set  {
ad_proc -deprecated -warn ad_locale_set_system_timezone {
ad_proc -deprecated -warn ad_locale_get_system_timezone { }  {
ad_proc -deprecated -warn ad_locale_system_tz_offset { } {
ad_proc -deprecated -warn ad_user_remove {
ad_proc -private -deprecated -warn apm_package_instantiate_and_mount {
ad_proc -deprecated -warn site_node_create {
ad_proc -deprecated -warn site_node_create_package_instance {
ad_proc -public -deprecated -warn site_node_mount_application {
ad_proc -deprecated -warn site_node {url} {
ad_proc -deprecated -warn set_form_variables {{error_if_not_found_p 1}} {
ad_proc -deprecated -warn set_form_variables_string_trim_DoubleAposQQ {} {
ad_proc -deprecated -warn set_the_usual_form_variables {{error_if_not_found_p 1}} {
ad_proc -deprecated -warn set_form_variables_string_trim_DoubleApos {} {
ad_proc -deprecated -warn set_form_variables_string_trim {} {
ad_proc -deprecated -warn ad_page_variables {variable_specs} {
ad_proc -deprecated -warn page_validation {args} {
ad_proc -public -deprecated sub_page_validation {args} {
ad_proc -deprecated -warn ReturnHeadersNoCache {{content_type text/html}} {
ad_proc -deprecated -warn ReturnHeadersWithCookie {cookie_content {content_type text/html}} {
ad_proc -deprecated -warn ReturnHeadersWithCookieNoCache {cookie_content {content_type text/html}} {
ad_proc -deprecated -warn ad_check_for_naughty_html {user_submitted_html} {
ad_proc -deprecated -warn ad_dateentrywidget_default_to_today {column} {
ad_proc -deprecated -warn nmc_IllustraDatetoPrettyDate {sql_date} {
ad_proc -deprecated -warn util_prepare_update {table_name primary_key_name primary_key_value form} {
ad_proc -deprecated -warn util_prepare_update_multi_key {table_name primary_key_name_list primary_key_value_list form} {
ad_proc -deprecated -warn util_prepare_insert {table_name form} {
ad_proc -deprecated -warn util_PrettySex {m_or_f { default "default" }} {
ad_proc -deprecated -warn util_PrettySexManWoman {m_or_f { default "default"} } {
ad_proc -deprecated -warn merge_form_with_ns_set {form set_id} {
ad_proc -deprecated -warn do_dml_transactions {dml_stmt_list} {
ad_proc -deprecated -warn with_transaction {body on_error} {
ad_proc -deprecated -warn string_contains_p {small_string big_string} {
ad_proc -deprecated -warn remove_whitespace {input_string} {
ad_proc -deprecated -warn util_just_the_digits {input_string} {
ad_proc -deprecated -warn leap_year_p {year} {
ad_proc -deprecated -warn set_csv_variables_after_query {} {
ad_proc -deprecated -warn util_aolserver_2_p {} {
ad_proc -deprecated -warn ad_chdir_and_exec { dir arg_list } {
ad_proc -deprecated -warn post_args_to_query_string {} {
ad_proc -deprecated -warn get_referrer_and_query_string {} {
ad_proc -deprecated -warn nmc_GetNewIDNumber {id_name} {
ad_proc -deprecated -warn database_to_tcl_string {db sql} {
ad_proc -deprecated -warn database_to_tcl_string_or_null {db sql {null_value ""}} {
ad_proc -deprecated -warn database_cols_to_tcl_string {db sql} {
ad_proc -deprecated -warn database_to_tcl_list {db sql} {
ad_proc -deprecated -warn database_to_tcl_list_list {db sql} {
ad_proc -deprecated -warn database_1row_to_tcl_list {db sql} {
ad_proc -deprecated -warn sortable_table_new_sort_order {column_list sort_column} {
ad_proc -deprecated -warn sortable_table {db select_string display_spec vars_to_export sort_var current_sort_order {table_length ""} {extra_table_parameters ""} {stripe_color_list ""} {max_results ""} {header_font_params ""} {row_font_params ""}} {
ad_proc -deprecated -warn ad_ssl_available_p {} {
ad_proc -public -deprecated -warn apm_version_file_list {
ad_proc -public -deprecated -warn apm_package_create_instance {
ad_proc -public -deprecated -warn ad_template_return {{file_stub ""}} {
Collapse
Posted by Jeff Davis on
Here are the places where removed functions are still present (Although I did not yet remove set_variables_after_query as it is used in ad_table and hence in some of the older admin interface).
Broken: 

set_the_usual_form_variables: 

contrib/packages/events/www/manage/event-price-ae-2.tcl:set_the_usual_form_variables
contrib/packages/events/www/manage/event-price-ae.tcl:set_the_usual_form_variables
contrib/packages/jabber/www/jabber-login.tcl:set_the_usual_form_variables
contrib/packages/jabber/www/jabber-login-greenthumb.tcl:set_the_usual_form_variables
contrib/packages/jabber/www/jabber-webstart-login.tcl:set_the_usual_form_variables
packages/ecommerce/www/admin/tools/spelling-dictionary-add-to.tcl:set_the_usual_form_variables
packages/jabber/www/jabber-login.tcl:set_the_usual_form_variables
packages/jabber/www/jabber-login-greenthumb-neu.tcl:set_the_usual_form_variables
packages/jabber/www/jabber-login-greenthumb.tcl:set_the_usual_form_variables
packages/jabber/www/jabber-webstart-login.tcl:set_the_usual_form_variables
packages/acs-admin/www/users/sessions-one-month.tcl:set_the_usual_form_variables
packages/acs-admin/www/users/sessions-registered-summary.tcl:set_the_usual_form_variables 0

ad_page_variables: 

packages/ecommerce/www/admin/tools/table-custom.tcl:ad_page_variables {item item_group return_url {delete_the_view 0} {col -multiple-list} {item_original {}}}
packages/ecommerce/www/admin/tools/form-custom.tcl:ad_page_variables {item item_group return_url {item_original {}} {delete_the_set 0}}
packages/ecommerce/www/admin/tools/sort-custom.tcl:ad_page_variables {item item_group return_url {delete_the_sort 0} {col -multiple-list} {dir -multiple-list} {item_original {}}}

page_validation:

contrib/packages/events/www/admin/spam/action-choose.tcl:page_validation {
contrib/packages/events/www/admin/spam/action-choose.tcl:    page_validation {
packages/ecommerce/www/admin/products/sale-price-edit-2.tcl:page_validation {
packages/ecommerce/www/admin/products/review-edit.tcl:page_validation {
packages/ecommerce/www/admin/products/sale-price-add.tcl:page_validation {
packages/ecommerce/www/admin/products/review-add.tcl:page_validation {
packages/ecommerce/www/admin/products/offer-add.tcl:page_validation {
packages/ecommerce/www/admin/products/offer-edit-2.tcl:page_validation {
packages/ecommerce/www/admin/products/edit-2.tcl:#page_validation {


with_transaction: 

packages/ecommerce/www/admin/tools/table-custom.tcl:with_transaction $db {
packages/ecommerce/www/admin/tools/form-custom.tcl:with_transaction $db {
packages/ecommerce/www/admin/tools/sort-custom.tcl:with_transaction $db {


set_variables_after_query
set_variables_after_query_not_selection:

contrib/packages/events/www/manage/event-price-ae.tcl:    set_variables_after_query
contrib/packages/events/www/manage/event-price-ae.tcl:    set_variables_after_query
packages/ecommerce/tcl/ec-audit-trail-procs.tcl:        set_variables_after_query
packages/acs-tcl/tcl/table-display-procs.tcl:             set_variables_after_query
packages/acs-tcl/tcl/table-display-procs.tcl:             set_variables_after_query_not_selection [lindex $Tpost_data_ns_sets [expr $Tpost_data - 1]]
packages/acs-tcl/tcl/table-display-procs.tcl:             set_variables_after_query_not_selection [lindex $Tpost_data_ns_sets [expr $Tpost_data - 1]] P
packages/acs-tcl/tcl/table-display-procs.tcl:             set_variables_after_query_not_selection $selection P
packages/acs-admin/www/users/sessions-one-month.tcl:    set_variables_after_query
packages/acs-admin/www/users/session-history.tcl:    set_variables_after_query
packages/acs-admin/www/users/sessions-registered-summary.tcl:    set_variables_after_query

Collapse
Posted by Torben Brosten on
Thanks for the motivation to upgrade, Jeff;) I added the ecommerce ones to the "now practical to use" bugtracker: https://openacs.org/bugtracker/openacs/bug?bug%5fnumber=2324