Forum OpenACS Improvement Proposals (TIPs): Re: TIP #144 Package Parameter Validation

Collapse
5: Re: TIP #144 Package Parameter Validation (response to 4)
Posted by Ryan Gallimore on 06/27/10 07:39 PM
Hi Torben,

Here is the patch, which includes an example.

Cheers,
Ryan

Collapse
6: Re: TIP #144 Package Parameter Validation (response to 5)
Posted by Dave Bauer on 06/30/10 06:27 PM
How about keying the implementation off the package key?

Then you can have one implementation per package that can validate all the parameters for that package.

Is that better or is having arbitrary implementations better for flexibility? The example seems to suggest keying on package key would simplify things.

Collapse
7: Re: TIP #144 Package Parameter Validation (response to 6)
Posted by Ryan Gallimore on 07/05/10 08:29 PM
Keying by package key instead of package id makes sense. The implementation body does not actually need to know the package key, it just needs to call the right package implementation.

So you could call:

callback -impl validate_${package_key} \
subsite::parameter_validate \
-parameter SubsiteSearchP]

which would return a validation list for inclusion into ad_form. I may have to catch the line above in case the package implementation doesn't exist yet.

The implementation for search would just include the validation code for search parameters (see the switch in attached patch).