Thanks Emma.
There was a problem with flushing the dotlrn*::get_site_template_id_not_cached *. I commited this fixes
last night. Now changing the defautl site template
from the dotlrn admin section works great for users
and communities.
And then the problem you mention with the recursive call to
get_site_template_id from get_site_template_id_not_cached.
Another thing related to this.
When you install the theme-selva package, it modifies
the 'DefaultMaster' parameter in the Main Subsite.
This brakes the changing site templates functionality.
My sugestion is to modify the install process of
selva in order to add it as a site template ( just like
Kelp and Sloan site templates , but we can talk about this
in the dotlrn chat meeting :).
Cheers,
Victor Guerra.