Forum OpenACS Development: Code changes in MyFirstPackage

i just wondered that i had to change the code to get the MyFirstPackage (see Development Tutorial) run.

mfp::note::add should called just with a title, but requires an item_id (in note-procs.tcl)

I changed the item_id to be optional.

# modified 2006/07/26 by nfl:
#          -item_id:required to optional
#          to match tutorial documentation
ad_proc -public mfp::note::add {
    -title:required
    -item_id
} {
    This proc adds a note.
} {
    if { [info exists item_id] eq 0 } {
        set item_id [db_nextval acs_object_id_seq]
    }

... following code unchanged.

Any comments from the gurus? 😉

Nils

i had just followed the tutorial... 😉

See https://openacs.org/doc/openacs-5-2/tutorial.html

And wondered that the given code needs to be fixed!?!

If i'm right, the tutorial should be updated...
If i'm wrong, please correct me...

Greetings,
Nils

okay, i'm not the first one encountering this topic... 😉
(Bug #1640)

Thank you for the url.

Nils

okay, i see, there exist better methods to deal with an empty item_id (see also Jun's Posting)...

... but the main point is, that the original tutorial source code says:

ad_proc -public mfp::note::add {
    -title:required
    -item_id:required
} {
    This proc adds a note.
} {  ...

I removed the :required-clause behind -item_id to match the tutorial description and get the code running.

That's why i'm wondering/asking... tutorial code shouldn't be needed to be fixed... 😉

Nils

yes, i got the app working. So it's no problem for me, just irritating/confusing... 😉

But maybe other people won't be able to fix the code.

And i think, most people won't expect such "tasks" in a tutorial... 😉

Anyway, my intention just was to ask if i was right. (I belong to the people that don't expect... and so on <smile>)

Nils

ad_proc -public mfp::note::add {
-title:required
-item_id
} {
This proc adds a note.
@return item_id of the new note.
} {
if { ! [info exists item_id] } {
set item_id[db_nextval acs_object_id_seq]
}
}
{
db_transaction {
set item_id [db_exec_plsql note_insert {
select content_item__new(:title,-100,null,null,null,null,null,null,\
'content_item','mfp_note',:title,null,null,null,null)
}]
set revision_id [db_nextval acs_object_id_seq]

I have another error:

[21/ago/2007:20:17:25][2997.3064855472][-conn:plataforma::3] Error: Error sourcing /home/jesusdavid/web/plataforma/packages/myfirstpackage/tcl/note-procs.tcl:
invalid command name "
db_transaction {
set item_id [db_exec_plsql note_insert {
select content_item__new(:title,-100,null,null,null,null,null,null,'content_item','mfp_note',:title,null,null,null,null)
}]

set revision_id [db_nextval acs_object_id_seq]

db_dml revision_add {
insert into mfp_notesi (item_id, revision_id, title)
values (:item_id, :revision_id, :title)
}

db_exec_plsql make_live {
select content_item__set_live_revision(:revision_id)
}
}
return $item_id
"
while executing
"{
db_transaction {
set item_id [db_exec_plsql note_insert {
select content_item__new(:title,-100,null,null,null,null,null,null,'content_item..."
(file "/home/jesusdavid/web/plataforma/packages/myfirstpackage/tcl/note-procs.tcl" line 44)
invoked from within
"source $__file "

Somebody can help me?

Thanks,

Silvia

Database operation "dml" failed (exception NSDB, "Query was not a DML or DDL command.")

SQL: insert into mfp_notesi(item_id, revision_id, title) values('3352', '3354', 'Silvia')
while executing
"ns_pg_bind dml nsdb0 { insert into mfp_notesi(item_id, revision_id, title) values(:item_id, :revision_id, :title) }"
("uplevel" body line 1)
invoked from within
"uplevel $ulevel [list ns_pg_bind $type $db $sql]"
("postgresql" arm line 2)
invoked from within
"switch $driverkey {
oracle {
return [uplevel $ulevel [list ns_ora $type $db $sql] $args]
}
..."
invoked from within
"db_exec dml $db $full_statement_name $sql"

MY CODE IS:

{
if { ! [info exists item_id] } {
set item_id[db_nextval acs_object_id_seq]
}

db_transaction {
db_exec_plsql note_insert {select content_item__new(:title,-100,:item_id,null,null,null,null,null,'content_item','mfp_note',:title,null,null,null,null)}

set revision_id [db_nextval acs_object_id_seq]

db_dml revision_add { insert into mfp_notesi(item_id, revision_id, title) values(:item_id, :revision_id, :title) }

db_exec_plsql make_live {
select content_item__set_live_revision(:revision_id)
}
}
return $item_id
}

Thanks before hand,

Silvia

Brian