Forum OpenACS Development: Re: Re: Bug Stomp (10th-11th august), join!

Collapse
Posted by Emmanuelle Raffenne on
Here are work done and results for tests on Oracle:

db__caching: we substitute "limit 0" for "where person_id=1 and person_id=2". Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=db__caching&package_key=acs-tcl&view_by=testcase&category=&quiet=0

datamodel__acs_object_type_check: we changed the variable name "__pk" to "the_pk". Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=datamodel__acs_object_type_check&package_key=acs-tcl&view_by=testcase&category=&quiet=0

datamodel__acs_attribute_check: we changed "order by object_type" to "order by a.object_type". Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=datamodel__acs_attribute_check&package_key=acs-tcl&view_by=testcase&category=&quiet=0

Now we will add missing types in the array (added types are between * *):

array set allow_types {
string {TEXT VARCHAR CHAR *VARCHAR2*}
boolean {BOOL INT2 INT4 *CHAR*}
number {NUMERIC INT2 INT4 INT8 FLOAT4 FLOAT8 *NUMBER*}
integer {INT2 INT4 INT8 *NUMBER*}
money {NUMERIC FLOAT4 FLOAT8}
timestamp {TIMESTAMPTZ}
time_of_day {TIMESTAMPTZ}
enumeration {INT2 INT4 INT8}
url {VARCHAR TEXT *VARCHAR2*}
email {VARCHAR TEXT *VARCHAR2*}
text {VARCHAR TEXT CLOB *VARCHAR2*}
keyword {CHAR VARCHAR TEXT *VARCHAR2*}
}

However we don't know what to do with timestamp type. On Oracle timestamp corresponds to the "date" datatype but on postgresql date and timestamp are different datatypes. Any idea will be wellcome.

process_objects_csv: person.new() requires "email" input arg . We added the email field in the csv file. Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=process_objects_csv&package_key=acs-tcl&view_by=testcase&category=&quiet=0

If there is no objection, I will commit those fixes.

ad_proc_fire_callback: the callback proc doesn't have the "-arg1" switch before arguments, we simply removed that switch. Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=ad_proc_fire_callback&package_key=acs-tcl&view_by=testcase&category=&quiet=0

I'm going to try to fix Test case ad_html_security_check_href_allowed now

Forget the above message, I wasn't testing as I should :)