Forum OpenACS Development: Re: Bug Stomp (10th-11th august), join!

Collapse
Posted by Raúl Morales Hidalgo on
We have fixed ad_proc_fire_callback (a missing "-" in the a_callback creation didn't create arg1 as a switch.
Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=ad_proc_fire_callback&package_key=acs-tcl&view_by=testcase&category=&quiet=0

However further testing will be apreciated as some weird results appear in the "callback returns value for each defined callback and catches the error callback" test although it does work ok.

We've also fixed community-core-procs-oracle.xql delete_person query, which was wrong.

Emmannuelle will commit the changes.

We're starting to create test cases for apm_parameter_register also, I will post when done.

Collapse
Posted by Emmanuelle Raffenne on
Everything committed. Thanks Raul.

We reran tests for acs-tcl, there are 3 that failed on Oracle:

datamodel__named_constraints

datamodel__acs_object_type_check

files__check_upgrade_ordering

Collapse
Posted by Don Baccus on
I've fixed the upper-case table names and related mostly-cosmetic/coding-standards stuff (since SQL is explicitly not case-sensitive) for acs-kernel and acs-messaging.

datamodel__acs_object_type_check now passes for PG, but still has upper-case stuff in acs-service-contract and acs-mail. acs-mail's being replaced by acs-mail-lite anyway, if someone wants to massage acs-service-contract, feel free.

Otherwise I may do it during the next stompfest.

Collapse
Posted by Emmanuelle Raffenne on
Don,

I got an error now when installing acs_messaging:

SQL*Plus: Release 9.2.0.4.0 - Production on Wed Aug 16 13:24:51 2006
Copyright (c) 1982, 2002, Oracle Corporation. All rights reserved.
Connected to:
Oracle9i Enterprise Edition Release 9.2.0.4.0 - Production
With the Partitioning and Oracle Data Mining options
JServer Release 9.2.0.4.0 - Production
begin
*
ERROR at line 1:
ORA-00001: unique constraint (OPENACS.ACS_OBJECT_TYPES_TABLE_NAME_UN) violated
ORA-06512: at "OPENACS.ACS_OBJECT_TYPE", line 28
ORA-06512: at line 13
No errors.
No errors.
No errors.
SQL> Disconnected from Oracle9i Enterprise Edition Release 9.2.0.4.0 - Production
With the Partitioning and Oracle Data Mining options
JServer Release 9.2.0.4.0 - Production

The SQL involved is (oracle/acs-messaging-create.sql):

acs_object_type.create_type (
supertype => 'content_revision',
object_type => 'acs_message_revision',
pretty_name => 'Message Revision',
pretty_plural => 'Message Revisions',
table_name => 'cr_revisions',
id_column => 'revision_id',
name_method => 'acs_object.default_name'
);

I will drop the unique constraint on acs_object_types.table_name on my local installation to be able to install and run the tests.