Forum OpenACS Development: OpenACS 5.9 Bugs in msg-type-procs.tcl and parameters.tcl

Collapse
1: OpenACS 5.9 Bugs in msg-type-procs.tcl and parameters.tcl
Posted by Frank Bergmann on 12/08/15 03:59 PM
Hi!

I believe we've found two "hard bugs" in OpenACS 5.9.0:

- acs-subsite/www/shared/parameters.tcl: $datatype is not defined, but used by TCL code. I've added a { datatype "" } in the ad_page_contract in our version...
- acs-service-contract/tcl/msg-type-procs.tcl: Syntax error with an additional parenthesis in line 39 with: if { $name eq "") } {

The situation looks pretty good apart from that, I hope we'll publish the second iteration of our ]po[ V5.0 VMware virtual machine today.

We've got "wget -r" working on automatic testing, that's been a big help so far.

Cheers,
Frank

Collapse
2: Re: OpenACS 5.9 Bugs in msg-type-procs.tcl and parameters.tcl (response to 1)
Posted by Gustaf Neumann on 12/09/15 10:24 PM
Dear Frank,

The first issue is probably a false positive, since parameters.xql defines a query "select_params", which returns the datataype (see [1]). How can this be different on ]po[?

The second issue is confirmed, fixed on cvs in the oacs-5-9 branch.

best regards
-g

[1] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-subsite/www/shared/parameters.xql#L27

Collapse
3: Re: OpenACS 5.9 Bugs in msg-type-procs.tcl and parameters.tcl (response to 2)
Posted by Frank Bergmann on 12/12/15 03:05 PM
Hi!

Got the issue:
There are two redundant and inconsistent queries, one in parameters.xql and one in parameters-postgresql.xql. The variant in parameters-postgresql.xql does NOT contain datatype in the select statement.

Cheers!
Frank

Collapse
4: Re: OpenACS 5.9 Bugs in msg-type-procs.tcl and parameters.tcl (response to 3)
Posted by Gustaf Neumann on 12/12/15 03:56 PM
Hi Frank,

in acs-subsite/www/shared/ in oacs-5-9 (or in the released tar file) there is no parameters-postgresql.xql (see [1]).

-g

[1] https://github.com/openacs/openacs-core/tree/oacs-5-9/packages/acs-subsite/www/shared