Forum OpenACS Development: OpenACS 5.9.0 Bug in /acs-admin/apm/version-parameters

Collapse
1: OpenACS 5.9.0 Bug in /acs-admin/apm/version-parameters
Posted by Frank Bergmann on 01/12/17 03:57 PM
Hi,

the "scope" variable is missing in version-parameters-postgresql.xql:

Before:
select parameter_name, coalesce(description, 'No Description') as description, datatype,
default_value, parameter_id, coalesce(section_name, 'No Section') as section_name
from apm_parameters
where package_key = :package_key
$sql_clauses

Corrected:

select parameter_name, coalesce(description, 'No Description') as description, datatype,
default_value, parameter_id, coalesce(section_name, 'No Section') as section_name, scope
from apm_parameters
where package_key = :package_key
$sql_clauses

Same holds of the Oracle version.

Cheers!
Frank

Collapse
2: Re: OpenACS 5.9.0 Bug in /acs-admin/apm/version-parameters (response to 1)
Posted by Gustaf Neumann on 01/12/17 08:04 PM
Hi Frank,

it seems to me that you fixed a local modification in the PO code. The scope parameter was introduced to OpenACS in April 2010, a log time before 5.9.0 was come out. See in [1] the content of the query in OpenACS 5.9.0 .... including the variable scope. So there is nothin to fix in OpenACS.

-g

[1] https://github.com/openacs/openacs-core/blob/openacs-5-9-0-final/packages/acs-admin/www/apm/version-parameters.xql