Forum OpenACS Development: Re: OpenACS 5.9.0 and Oracle 12c

Collapse
5: Re: OpenACS 5.9.0 and Oracle 12c (response to 4)
Posted by Maurizio Martignano on 03/03/17 06:06 AM
Hello Brian, good job.

Did you modify Naviserver code, or Nsoracle?
If so, would it be possible to get your mods?

TIA,
Maurizio

Collapse
7: Re: OpenACS 5.9.0 and Oracle 12c (response to 5)
Posted by Brian Fenton on 03/03/17 10:32 AM
Hi Maurizio

it is you who has done a good job! I didn't have to modify anything, it worked out of the box. I used the nsoracle.dll that you include in your release.

There is one issue of concern I noticed yesterday evening, that I need to spend more time looking at. Calls to ::util::http::get are failing.
See this bug https://openacs.org/bugtracker/openacs/bug?format=table&bug_number=3307

thanks
Brian

Collapse
10: Re: OpenACS 5.9.0 and Oracle 12c (response to 7)
Posted by Maurizio Martignano on 03/03/17 04:05 PM
Ah... Ok. Thank you.
While waiting for the bug fix, where i need to do some investigation, you can try something like this:
[exec wget https://openacs.org]

Kind of awkward... but it should work...

Maurizio

Collapse
11: Re: OpenACS 5.9.0 and Oracle 12c (response to 10)
Posted by Antonio Pisano on 03/03/17 04:12 PM
Another way to circumvent the issue for the time being could be to try the curl implementation of HTTP client, e.g. util::http::get -preference curl -url https://openacs.org

For reference see https://openacs.org/api-doc/proc-view?proc=util%3a%3ahttp%3a%3aget&source_p=1

Collapse
13: Re: OpenACS 5.9.0 and Oracle 12c (response to 10)
Posted by Brian Fenton on 03/03/17 04:51 PM
Thank you Maurizio. Actually what is the canonical way to make a HTTP call with Naviserver? In our old AOLserver codebase, we have a mix of calls to ns_httpget, ad_httpget, and more recently calls to ns_http (this is the one that works best for us on Windows 2008).
Collapse
14: Re: OpenACS 5.9.0 and Oracle 12c (response to 13)
Posted by Maurizio Martignano on 03/03/17 11:18 PM
I have fixed the issue.

This is the change in the code:

if (connect(sock, saPtr, Ns_SockaddrGetSockLen(saPtr)) != 0) {
int err = ns_sockerrno;

#ifndef _WIN32
if (!async || (err != EINPROGRESS && err != EWOULDBLOCK)) {
#else
if (!async || (err != WSAEWOULDBLOCK)) {
#endif
ns_sockclose(sock);
Ns_LogSockaddr(Warning, "SockConnect fails", saPtr);
sock = NS_INVALID_SOCKET;

The mod will be available in next version of my distribution.
Over the weekend.

Collapse
15: Re: OpenACS 5.9.0 and Oracle 12c (response to 13)
Posted by Antonio Pisano on 03/05/17 09:06 PM
Regarding this, ns_http is now the preferred low-level interface for HTTP client functionalities. A higher level interface, that deprecates all the "old school" procs like ad_httpget and such, you can find in [1] and [2].

These are basically wrappers around the API that make easier to issue the requests, also providing backward compatibility with Aolserver by using curl.

Hope this helps

Antonio

[1] https://openacs.org/api-doc/proc-view?proc=util%3a%3ahttp%3a%3aget&source_p=1
[2] https://openacs.org/api-doc/proc-view?proc=util%3a%3ahttp%3a%3apost&source_p=1

Collapse
16: Re: OpenACS 5.9.0 and Oracle 12c (response to 15)
Posted by Brian Fenton on 03/06/17 10:20 AM
Thanks Antonio!