Forum OpenACS Development: Re: Calendar pkg: call_item and acs_activity

Collapse
2: Re: Calendar pkg: call_item and acs_activity (response to 1)
Posted by Iuri Sampaio on 03/04/18 07:10 PM
Good news. I've just found xotcl's proc that does the job. i.e.

::xo::db::sql::acs_activity delete -activity_id XXXX

/api-doc/proc-view?proc=%3a%3axo%3a%3adb%3a%3asql%3a%3aacs_activity+proc+delete&source_p=1

Best wishes,

Collapse
3: Re: Calendar pkg: call_item and acs_activity (response to 2)
Posted by Iuri Sampaio on 03/04/18 07:11 PM
Peharps, it is time to add xotcl's proc into caledar's pkg.
Collapse
4: Re: Calendar pkg: call_item and acs_activity (response to 3)
Posted by Antonio Pisano on 03/05/18 10:30 AM
Dear Iuri,

the technical reason why activities don't get removed automatically at the removal of a cal_item is this: cal_items.cal_item_id references acs_events.event_id, but no ON DELETE behavior is defined. On the other hand, acs_events.event_id references acs_activities.activity_id and there we have ON DELETE SET NULL defined. Therefore, is not clear to me whether automatic deletion of related activity and event tuples is fine in general for all packages that reuse acs-events.

I will try to have a deeper look, in the meantime whoever might have better insight could give some comments.

Ciao

Antonio

Collapse
5: Re: Calendar pkg: call_item and acs_activity (response to 4)
Posted by Antonio Pisano on 03/05/18 10:36 AM
Mmm...

actually, if one looks at calendar::item::delete -cal_item_id https://openacs.org/api-doc/proc-view?proc=calendar::item::delete&source_p=1, this should call ca_item__delete stored procedure https://openacs.org/api-doc/plsql-subprogram-one?name=cal_item__delete&type=FUNCTION, which should in fact remove the acs_event.

Are you making use of this API? Or you're deleting via some custom code?

Ciao

Collapse
6: Re: Calendar pkg: call_item and acs_activity (response to 5)
Posted by Iuri Sampaio on 03/06/18 11:29 PM
Indeed Antonio,
I've used cal_item__delete and I haven't touched into the core's ad_procs.

Pkg versions are:
provides url="calendar" version="2.6.1d3"/
provides url="acs-events" version="0.6.1.1"
provides url="acs-kernel" version="5.9.1"/

I've noticed the dependencies (relationships) among calendar, acs-events and so, while I was debugging the "code workflow".

Thanks for the lesson! I understand why acs-events supports calendar pkg. It makes total sense.

Best wishes,