Forum OpenACS Development: Comments on files in file storage

1: Comments on files in file storage

Posted by Caroline Meeks on 12/04/02 05:41 PM

The design doc says:

Future Improvements/Areas of Likely Change Allow people to comment on files (and versions and folders?)

This was in 3x. Has anyone done this yet for 4x?

2: Re: Comments on files in file storage (response to 1)

Posted by Caroline Meeks on 12/05/02 04:22 AM

Putting comments on a file into the file details page was pretty easy:

Index: file.tcl
===================================================================
RCS file: /usr/local/cvsroot/ssv2/packages/file-storage/www/file.tcl,v
retrieving revision 1.6
diff -r1.6 file.tcl
91c91,92
<
---
> set gc_link [general_comments_create_link $file_id "[ad_conn url]?file_id=$file_id"]
> set gc_comments [general_comments_get_comments $file_id]

And corresponding changes to display in file.adp..not shown because bbaord doesn't like the tags.

If general-comments is not mounted it just quietly does nothing.

Should this go into to OACS? I'd say yes, its good to have examples of how the packages work together. Do we need to put a check to see if general-comments is installed?

3: Re: Comments on files in file storage (response to 1)

Posted by Roberto Mello on 12/05/02 05:11 AM

It'd be nice to have this in 4.6 since it doesn't require any datamodel changes, but it's up to Don/Janine.

-Roberto

4: Re: Comments on files in file storage (response to 1)

Posted by Lars Pind on 12/05/02 09:17 AM

Yeah, please throw it in there.

You may want to make it a package parameter so you can turn it off.

/Lars

5: Re: Comments on files in file storage (response to 1)

Posted by Caroline Meeks on 12/09/02 09:08 PM

I put in the parameter. Jeff said he'd translate as necesary for postgres and move to OACS4.6

I did run into a couple of problems that relate to dotLRN. I'm going to post about them in the dotlrn forum now.

6: Re: Comments on files in file storage (response to 5)

Posted by Jeff Davis on 12/09/02 11:45 PM

I committed the patch on 4.6.

7: Re: Comments on files in file storage (response to 6)

Posted by Caroline Meeks on 12/10/02 02:04 AM

Thanks Jeff! Much appreciated.