Forum OpenACS Improvement Proposals (TIPs): TIP #117 (IMPLEMENTED): Remove md5-procs from acs-tcl

Request notifications

md5-procs.tcl appears to be a copy of a previous version of the md5 implementation in tcllib. Now that we requires tcllib, it is provided and there's no need to keep it in acs-tcl.
Collapse
Posted by Dave Bauer on
Approve
Collapse
Posted by Don Baccus on
approved
Collapse
Posted by Victor Guerra on
Approve
Collapse
Posted by Gustaf Neumann on
approved
Collapse
Posted by Malte Sussdorff on
approved. Is there any work involved to make the "switch" ?
Collapse
Posted by Emmanuelle Raffenne on
Malte,

No, there's no work involved. I'm not sure md5 is even used, I've grep'd core+dotlrn and didn't find any use of it.

I don't think it is used at all, probably some legacy code we got from acs.

Approved.

Collapse
Posted by Mark Aufflick on
It was used in 4.x email/mime handling. md5.tcl. base64.tcl and mime.tcl used to be nastily sourced in because of aolserver 3's poor package handling.

Eg:

http://cvs.openacs.org/cvs/openacs-4/packages/acs-tcl/tcl/html-email-procs.tcl?rev=1.2&view=auto

It's not been used for some time I believe.

Collapse
Posted by Emmanuelle Raffenne on
Done and committed to HEAD.