Forum OpenACS Improvement Proposals (TIPs): Re: Tip #121: acs_log Logging for APM Upgrade Script Output

Collapse
2: Re: Tip #121: acs_log Logging for APM Upgrade Script Output (response to 1)
Posted by Dave Bauer on 04/28/08 02:13 PM
This sounds like a great idea.

I have a couple of questions.

Looks like log_key is limited varchar(100). This is probably not long enough to hold the path to all sql files. Maybe it is, but seems like it might run out.

Also I think the db_string calls would more correctly be db_exec_plsql.

Collapse
3: Re: Tip #121: acs_log Logging for APM Upgrade Script Output (response to 2)
Posted by Frank Bergmann on 04/28/08 02:26 PM
I've found 100 chars to be sufficient to hold the upgrade script's filename. However, yes, extending that wouldn't hurt probably, maybe varchar(400) or is more suitable and works on both Oracle and PG.

I actually haven't seen acs_log to be used much, so the impact should be small.

db_exec_plsql

No problems with that if you think it's more correct. We used to use the function, too, but there is actually no big difference in practical terms, isn't it?

Cheers,
Frank