Forum OpenACS Q&A: Problems with Enhanced-News package

I believe the problem is in the procedures specifically created for this package (i.e. news_get_user_priviledge), call old functions (ad_admistrator_p) that have been redefined and lack the "db" argument they needed before. For example, inside news_get_user_priviledge, ad_administrator_p is called like this:

[ad_administrator_p $user_id]

[ad_administrator_p $db $user_id]

set db [ns_db gethandle]

Error: dbinit: db handle limit exceeded: thread already owns 1 handle
from pool 'main'

    ... 4.x calls ...
    db_release_unused_handles
    set db [ns_db gethandle]
    set admin_p [ad_permission_p $db site_wide]
    ns_db releasehandle $db
    ... back to 4.x API ...

Error: can't read "db": no such variable
can't read "db": no such variable

The previous solution, getting and releasing the handle before ad_administrator_p is called, is fine when I call it directrly from the script, but doesn't work if I do it inside another procedure. For example:

proc_doc news_is_admin_p { user_id news_group_id} { Check if the 
user is a site-wide administrator or an admin for the newsgroup (can 
either be a member of the admin group, or the admin (role) of the 
newsgroup if admin_group_id is null). If yes, then 1 is returned. 
Otherwise, 0 is returned.} {
    # if site-wide admin, returns 1

    db_release_unused_handles
    set db [ns_db gethandle]
    if [ad_administrator_p $db $user_id] {
        return 1
    }
    ns_db releasehandle $db

 
    set admin_list [news_get_admins $news_group_id]
 
    if { [lsearch $admin_list $user_id] != -1 } {
        return 1
    } else {
        return 0
    }
}

Error: dbinit: db handle limit exceeded: thread already owns 1 
handle from pool 'main'

and I've tried with diferent pools.

I thought it could work to define a new ad_administrator_p_mine, 
and substitute ad_administrator_p by ad_administrator_p_mine 
everywhere in this module:

proc_doc ad_administrator_p_mine {{user_id}} {
    db_release_unused_handles
    set db [ns_db gethandle]
    return [ad_administrator_p $db $user_id]
    ns_db releasehandle $db
}


but again...

Error: dbinit: db handle limit exceeded: thread already owns 1 
handle from pool 'main'


and I've also tried different pools.

I run out of ideas, so what I'm doing, which is working quite 
well, is porting these functions from the ACS code. For the moment, 
the functions I need are not very complicated and the database 
queries are almost similar for oracle and postgres. For example:

proc_doc ad_administrator_p2 { {user_id ""} } {
    Returns 1 if the user is part of the site-wide administration 
group. 0 otherwise.
} {
    if [empty_string_p $user_id] {
        set user_id [ad_verify_and_get_user_id]
    }

    set ad_group_member_p [db_string user_is_group_member {
        select ad_group_member_p(:user_id, group_id) as member_p
        from   user_groups
        where  short_name = 'SWA'
    }]

    return [ad_decode $ad_group_member_p "t" 1 0]
}


But if someone has a better idea, it will be welcome.
Thanks for the help

proc_doc db_with_3x_wrapper { code } {
    executes $code in uplevel, after allocating a db handle named $db
} {
    uplevel "
        db_release_unused_handles
        set db [ns_db gethandle]
        $code
        ns_db releasehandle $db
    "
}

I'm still trying to make it work on if statements inside some procedures. For example:

proc news_is_admin_p { user_id news_group_id} {
    db_with_3x_wrapper {
      if [ad_administrator_p $db $user_id] {
        return 1
      }
    }

    ...
}

leaves the handle open since the return goes before the releasehandle.

To your question of what I meant when I said I tried with different polls, I mean that instead of set db [ns_db gethandle] y tried set db [ns_db gethandle subquery] or even new one I set up in nsd.tcl. That's what you meant yesterday when you said I should allocate my handles in another pool, isn't it?

Since I'm still getting server log errors of the type Error: could not allocate 1 handle from pool "whatever", I'm testing this wrapper via nscp:

1>db_with_3x_wrapper {set member_p [ad_user_group_member $db 1 14]}

2>return $set_member_p
0
3>b_with_3x_wrapper {set member_p [ad_user_group_member $db 1 1]}
could not allocate 1 handle from pool "whatever"

The same happens with this other example I yesterday thought was working well

db_with_3x_wrapper { set is_admin_p [ad_administrator_p $db 1]}

So the previous handle has somehow not been released!! I think the problem is something I mentioned yesterday: the output of ad_user_group_member (for this particular case) is a return, so the wrapper is left before the ns_db releasehandle $db is reached.
Am I right?
Is there any way to fix it?
Shouldn't the db_release_unused_handles line in db_with_3x_wrapper release this handle before trying to get a new one?

proc news_get_user_priviledge {user_id } {
    db_with_3x_wrapper {
        if [ad_administrator_p $db $user_id] {
            return "Post"
        }
    }
 
    set priviledge ""
    db_foreach check_priviledge "
    select group_id
    from newsgroups
    where enabled_p = 't'" {
        db_with_3x_wrapper { 
          set member_p [ad_user_group_member $db $group_id $user_id]
	  }
        if $member_p {
            set priviledge "Suggest"
        }
    }
    return $priviledge
}

ReturnHeaders
 
set result [news_get_user_priviledge2 1]
 
ns_write "$result"

Works for user_id > 1 but user_id=1 returns:

Error: could not allocate 1 handle from pool "whatever"
could not allocate 1 handle from pool "whatever"
    while executing
"ns_db gethandle whatever"
    (procedure "db_with_3x_wrapper" line 4)
    invoked from within
"db_with_3x_wrapper {
          set member_p [ad_user_group_member $db $group_id $user_id]
          }"
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $code_block "
    ("1" arm line 1)
    invoked from within
"switch $errno {
                0 {
                    # TCL_OK
                }
                1 {
                    # TCL_ERROR
                    global errorInfo errorCode
                    error $error $errorInfo $errorCode
                }
                2 {
        ..."
    ("while" body line 20)
    invoked from within
"while { [db_getrow $db $selection] } {
            incr counter
            if { [info exists array_val] } {
                unset array_val
            }
            if { ![info exists column..."
    ("uplevel" body line 5)
    invoked from within
"uplevel 1 $code_block "
    invoked from within
"db_with_handle db {
        set selection [db_exec select $db $statement_name $sql]

        set counter 0
        while { [db_getrow $db $selection] } {
            incr counter..."
    (procedure "db_foreach" line 32)
    invoked from within
"db_foreach check_priviledge "
    select group_id
    from newsgroups
    where enabled_p = 't'" {
        db_with_3x_wrapper {
          set member_..."
    (procedure "news_get_user_priviledge" line 9)
    invoked from within
"news_get_user_priviledge 1"
    invoked from within
"set done [news_get_user_priviledge 1]"
    (file "/web/hezkuntza/www/enhanced-news/example2.tcl" line 27)
    invoked from within
"source $script"
    (procedure "ns_sourceproc" line 6)
    invoked from within
"ns_sourceproc cns1 {}"