Forum OpenACS Development: Attachments and acs-mail-lite

Collapse
1: Attachments and acs-mail-lite
Posted by Ryan Gallimore on 10/15/11 06:31 AM
acs-mail-lite uses the cr_items.name for the filename of the attachment.

When content::item::upload_file is used, the name is rewritten without an extension. This often confuses mail clients. However, cr_revisions.title retains the original filename.

Any complaints if I change the attachment filename to use cr_revisions.title instead of cr_items.name?

Collapse
2: Re: Attachments and acs-mail-lite (response to 1)
Posted by Emmanuelle Raffenne on 10/15/11 10:53 AM
Hi Ryan,

If you change the attachment to be "title" and the file actually has a title or doesn't have any (blank), then the attachment tagging won't work correctly and the file will be sent with no name.

I think it's upload_file that needs to be fixed, there's no reason to store the name of the item without extension. In 5.6 the line that removes the extension of the filename to fill the title is commented. What openacs version are you using?

Collapse
3: Re: Attachments and acs-mail-lite (response to 2)
Posted by Ryan Gallimore on 10/15/11 11:18 PM
Hi Emma,

Good point regarding a null title. I am using 5.6.

The name is sanitized by util_text_to_url in upload_file.

I would suggest changing the regexp to allow for a period:

# substitute all non-word characters
regsub -all {([^a-z0-9\.])+} $text $replacement text

This sets the name with a proper extension unless there are name conflicts, in which case file.pdf becomes file.pdf_2.

Collapse
4: Re: Attachments and acs-mail-lite (response to 3)
Posted by Ryan Gallimore on 10/18/11 05:32 PM
Emma, do you think it is reasonable to include the extension period and alter the unique numbering from something like file.pdf_2 to file-2.pdf?

This would solve the problem of opening attachments in some e-mail clients.

Collapse
5: Re: Attachments and acs-mail-lite (response to 4)
Posted by Emmanuelle Raffenne on 10/18/11 05:35 PM
Hi Ryan,

It's better than modifying the extension IMO.

Collapse
6: Re: Attachments and acs-mail-lite (response to 5)
Posted by Dave Bauer on 10/18/11 05:39 PM
Yes, you need to split the filename and extension, then generate the unique filenames then put the extension back on.

text_to_url doesn't care about extensions since it just generates a unique URL which doesn' need one, so reusing for this purpose requires some extra logic.

Collapse
7: Re: Attachments and acs-mail-lite (response to 1)
Posted by Tory Pitt on 01/23/12 08:39 PM
I find this post very informative. Thank you very much.