Forum OpenACS Development: Re: Attachments and acs-mail-lite

Posted by Ryan Gallimore on
Hi Emma,

Good point regarding a null title. I am using 5.6.

The name is sanitized by util_text_to_url in upload_file.

I would suggest changing the regexp to allow for a period:

# substitute all non-word characters
regsub -all {([^a-z0-9\.])+} $text $replacement text

This sets the name with a proper extension unless there are name conflicts, in which case file.pdf becomes file.pdf_2.

Posted by Ryan Gallimore on
Emma, do you think it is reasonable to include the extension period and alter the unique numbering from something like file.pdf_2 to file-2.pdf?

This would solve the problem of opening attachments in some e-mail clients.

Posted by Emmanuelle Raffenne on
Hi Ryan,

It's better than modifying the extension IMO.

Posted by Dave Bauer on
Yes, you need to split the filename and extension, then generate the unique filenames then put the extension back on.

text_to_url doesn't care about extensions since it just generates a unique URL which doesn' need one, so reusing for this purpose requires some extra logic.