Forum OpenACS Development: Warning: has no doc(title) set.

Posted by Cesareo Garcia Rodicio on 10/29/13 12:40 PM

I'm upgrading a quite old server (5.5) to 5.8 and I'm finding some warnings/errors) so I decided to put it here with a descriptive subject just in case anybody has same problems.

I found a "Warning: /fotos/ has no doc(title) set.".

* Reason (I think):
There is no "doc list" and default-master.adp don't load it in

<if @doc@ defined><property name="&doc">doc</property></if>

* A solution that is working for me:
I fixed this adding in default-master.tcl :

set doc(title) $title (title it is defined)

2: Re: Warning: has no doc(title) set. (response to 1)

Posted by Gustaf Neumann on 10/29/13 07:58 PM

The change to use doc(title) happened years ago. blank-master.tcl says since May 2007:

  @property doc(title)        The document title, ie. <title /> tag.
  @property doc(title_lang)   The language of the document title, if different
                              from the document language.

Anyhow, over the last months, I have fixed dozens of occurrences in packages, that do not properly set/propagate doc(title). Is /fotos an instance of photo-album? If so, upgrade to the head version.

3: Re: Warning: has no doc(title) set. (response to 2)

Posted by Cesareo Garcia Rodicio on 10/29/13 08:03 PM

I'd checked blank-master.tcl but I did't know where was the right place to set it up. It happened in photo-album but also in some custom (simple) pages.

If you'd like I can remove my "patch" and post here the warnings in my installation

4: Re: Warning: has no doc(title) set. (response to 3)

Posted by Gustaf Neumann on 10/29/13 08:07 PM

please upgrade the photo-album package to the HEAD version in cvs.

6: Re: Warning: has no doc(title) set. (response to 4)

Posted by Cesareo Garcia Rodicio on 10/30/13 02:11 PM

Sorry for the delay. To install package from cvs HEAD I had to do some configuration (I had git in my openacs installation and I've forgot a lot about cvs).

Anyway, I installed some packages from HEAD and the warning dissappear.

I'm going to upgrade other packages (lars-blogger, edit-this-page ...) and see my logs (but I suppose it was the same problem)

Thanks!

7: Re: Warning: has no doc(title) set. (response to 6)

Posted by Gustaf Neumann on 10/30/13 06:47 PM

We should find a better way to handle this. Probably the easiest way to handle this is to make all 5.8.* packages available via "upgrade from repository". One limiting factor is currently that changes outside "/packages/" are not available this way (could be done via an upgrade script that copies these files to their destination).

9: Re: Warning: has no doc(title) set. (response to 7)

Posted by Cesareo Garcia Rodicio on 10/31/13 12:52 AM

Yes, I think so. "Upgrade from Repository" is the easy (and fast) way (at least to me).

But, in the mean time, I can test via cvs update

5: Re: Warning: has no doc(title) set. (response to 1)

Posted by Jim Lynch on 10/30/13 07:04 PM

there are three master pages that call each other, and the files are in the www dir of your service dir (where you should find license and readme.txt, etc, packages, etc).

They are each separated into .adp and .tcl, and they are called blank-master, default-master and site-master. The .tcl files have varying amounts of info, with blank-master.tcl having the most extensive, and it is this file which describes doc(title) and other variables and procs, all useful to customize the page that calls <master>.

Take a look at (your service)/www/blank-master.tcl to read about everything these master templates can do.

8: Re: Warning: has no doc(title) set. (response to 5)

Posted by Cesareo Garcia Rodicio on 10/31/13 12:34 AM

Hi Jim

But I think the problem might be with some packages that do not "propagate" (I mean, set up) the doc(title) property

Thanks!