Forum OpenACS Development: Re: Bug Stomp (10th-11th august), join!

Collapse
Posted by Emmanuelle Raffenne on

Tests results on Oracle server:

Package keyTestcases runPassesFailsResult
acs-admin 2 3 0 OK
acs-api-browser 1 1 0 OK
acs-authentication 24 228 1 FAILED
acs-automated-testing 1 0 0 OK
acs-content-repository 7 39 1 FAILED
acs-lang 15 357 0 OK
acs-mail 1 2 0 OK
acs-messaging 2 2 0 OK
acs-service-contract 1 1 0 OK
acs-subsite 3 3 1 FAILED
acs-tcl 53 301 96 FAILED
acs-templating 6 41 10 FAILED

Compared to results posted by Nick, there's more.

Few tests failed because queries syntax are not compatible with Oracle. We start working on those to fix the oracle part:

db__caching
SQL: select first_names from persons limit !>>>!0, stack trace: 
nsoracle.c:3904:ora_tcl_command: error in `OCIStmtExecute ()':
 ORA-00933: SQL command not properly ended

SQL: select first_names from persons limit !>>>!0
    while executing
"ns_ora 0or1row nsdb0 {select first_names from persons limit 0}"
datamodel__acs_object_type_check
Type acs_object: select object_id from acs_objects failed:
nsoracle.c:3904:ora_tcl_command: error in `OCIStmtExecute ()':
 ORA-00911: invalid character

SQL: select object_id as !>>>!__pk from acs_objects limit 1
datamodel__acs_attribute_check
SQL: select a.*, lower(ot.table_name) as obj_type_table 
     from acs_attributes a, acs_object_types ot 
     where ot.object_type = a.object_type 
     order by !>>>!object_type, stack trace: 
nsoracle.c:3904:ora_tcl_command: error in `OCIStmtExecute ()':
 ORA-00918: column ambiguously defined
process_objects_csv
process_objects_csv (body 0): Error during execution: 
Setup failed with error nsoracle.c:3542:ora_tcl_command: error in `OCIStmtExecute ()':
 ORA-06550: line 4, column 13:
PLS-00306: wrong number or types of arguments in call to 'NEW'
ORA-06550: line 4, column 7:
PL/SQL: Statement ignored

SQL: 
      
    BEGIN
      :1 := person.new(creation_user    => :creation_user,
                                   creation_ip      => :creation_ip,
                                   first_names      => :first_names,
                                   last_name        => :last_name
      );
    END; 
Collapse
Posted by Raúl Morales Hidalgo on
Hi there!,

I'm going to try to pass the tests on ad_proc_fire_callback on the oracle test server that Emmanuelle posted.

Collapse
Posted by Emmanuelle Raffenne on
Here are work done and results for tests on Oracle:

db__caching: we substitute "limit 0" for "where person_id=1 and person_id=2". Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=db__caching&package_key=acs-tcl&view_by=testcase&category=&quiet=0

datamodel__acs_object_type_check: we changed the variable name "__pk" to "the_pk". Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=datamodel__acs_object_type_check&package_key=acs-tcl&view_by=testcase&category=&quiet=0

datamodel__acs_attribute_check: we changed "order by object_type" to "order by a.object_type". Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=datamodel__acs_attribute_check&package_key=acs-tcl&view_by=testcase&category=&quiet=0

Now we will add missing types in the array (added types are between * *):

array set allow_types {
string {TEXT VARCHAR CHAR *VARCHAR2*}
boolean {BOOL INT2 INT4 *CHAR*}
number {NUMERIC INT2 INT4 INT8 FLOAT4 FLOAT8 *NUMBER*}
integer {INT2 INT4 INT8 *NUMBER*}
money {NUMERIC FLOAT4 FLOAT8}
timestamp {TIMESTAMPTZ}
time_of_day {TIMESTAMPTZ}
enumeration {INT2 INT4 INT8}
url {VARCHAR TEXT *VARCHAR2*}
email {VARCHAR TEXT *VARCHAR2*}
text {VARCHAR TEXT CLOB *VARCHAR2*}
keyword {CHAR VARCHAR TEXT *VARCHAR2*}
}

However we don't know what to do with timestamp type. On Oracle timestamp corresponds to the "date" datatype but on postgresql date and timestamp are different datatypes. Any idea will be wellcome.

process_objects_csv: person.new() requires "email" input arg . We added the email field in the csv file. Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=process_objects_csv&package_key=acs-tcl&view_by=testcase&category=&quiet=0

If there is no objection, I will commit those fixes.

ad_proc_fire_callback: the callback proc doesn't have the "-arg1" switch before arguments, we simply removed that switch. Results: http://openacs.innova.uned.es/test/admin/testcase?testcase_id=ad_proc_fire_callback&package_key=acs-tcl&view_by=testcase&category=&quiet=0

I'm going to try to fix Test case ad_html_security_check_href_allowed now

Forget the above message, I wasn't testing as I should :)