Forum OpenACS Development: Re: Problems with SuppressHttpPort

Posted by Gustaf Neumann on

The function join_location is the wrong place to address the problem, since one might wish to use the function also for other servers, addressed e.g. via ns_http.

I am still not sure, why this happens in your installation. If I understand correctly, this happens via redirects, which should always go through ad_returnredirect, which calls for resolving util_current_location. In this function, ReverseProxyMode etc. is handled.

Did you only install NaviServer or as well OpenACS? If you installed OpenACS with the default configuration parameters, then you should have OpenACS 5.9.1 installed. Correct?

Posted by Raul Rodriguez on

Yes I have OpenACS 5.9.1 installed following said installation.

After running OpenACS installation script I navigated to it via Firefox:

  • I entered the setup information and restarted the server.
  • A screen came up with a list of Applications and Subsites.
  • logged on to it and got a certificate via letscencrypt per README
  • At Main Site Parameters restricted site to ssl via set RestrictToSSL using '*'
  • in acs-tcl set SuppressHttpPort 1
  • Restarted OACS
  • Went to from another browser (Chrome) that had never gone to the site.
  • Chrome showed url with port

I verified that util_current_location is returning a result with no port as expected.

The port is added at some point later. I think this is happening in rp_filter via security::redirect_to_secure via security::get_secure_location where join_location is called.


    # Check, if we are supposed to upgrade insecure requests. This                                            
    # should be after the canonical check to avoid multiple redirects.                                        
    # ns_set get accepts a default value in 3rd argument only on                                              
    # NaviServer; so perform the check in two steps for AOLserver                                             
    # compatibility.                                                                                          
    set upgrade_insecure_requests_p [ns_set get [ns_conn headers] Upgrade-Insecure-Requests]                 \

    if {$upgrade_insecure_requests_p ne "" &&
        && [security::https_available_p]
        && ![security::secure_conn_p]
    } {
        security::redirect_to_secure -script_abort=false [ad_return_url -qualified]
        return filter_return
Posted by Gustaf Neumann on
Dear Raul, many thanks for the good report!

So, the problem is probably the upgrade to secure, i.e. when connecting via HTTP to a site requiring HTTPS , having SuppressHttpPort set. Can you apply the change [1] to your installation and check whether this helps? If so, i'll do the same change on HEAD and add some test cases.

all the best


Posted by Raul Rodriguez on

I applied the patch and works as expected. Going to returns with no port.

Thank you

Posted by Gustaf Neumann on

I've updated the oacs-5-9 branch, increased version number and re-tagged, such that OpenACS 5.9 users can also do a "upgrade from repository".

In the HEAD branch, i did similar (did some more cleanup, including a small regression test, ...)

all the best

Posted by Raul Rodriguez on

Went to

The "ACS Site-Wide Administration" link has the port,

Does the logic need to be updated to include a check for SuppressHttpPort?

The link uses util::configured_location


ad_page_contract {
    @author Bryan Quinn (
    @author Michael Bryzek (

    @creation-date August 15, 2000
    @cvs-id $Id: index.tcl,v 2016/09/02 17:33:19 gustafn Exp $
} {
} -properties {

array set this_node [site_node::get -url [ad_conn url]]
set title "Subsite [_ acs-subsite.Administration]: $this_node(instance_name)"

set acs_admin_url [apm_package_url_from_key "acs-admin"]
array set acs_admin_node [site_node::get -url $acs_admin_url]
set acs_admin_name $acs_admin_node(instance_name)
set sw_admin_p [permission::permission_p -party_id [ad_conn user_id] -object_id $acs_admin_node(object_id) -privilege adm\
set full_acs_admin_url [util::configured_location]$acs_admin_url

set convert_subsite_p [expr { [llength [apm::get_package_descendent_options [ad_conn package_key]]] > 0 }]


ad_proc -public util::configured_location {} {

    Return the configured location as configured for the current
    network driver. While [util_current_location] honors the virtual
    host information of the host header field,
    util::configured_location returns the main configured location
    (probably the main subsite). This also differs from [ad_url],
    which returns always the same value from the kernel parameter,
    since it returns either the https or http result.

    @return the configured location in the form "proto://hostname?:port?"

    @see ad_url
    @see util_current_location
} {
    set driver_info [util_driver_info]
    return [util::join_location \
		-proto    [dict get $driver_info proto] \
		-hostname [dict get $driver_info hostname] \
		-port     [dict get $driver_info port]]

Thank You